Max/crates io prep v2 #6270
Max/crates io prep v2 #6270
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Cargo.toml
Outdated
|
|
||
| # sdk related deps so we can pull in workspace versions of these in other crates' cargo files, and not have to define the version everywhere | ||
| # nym-api = { version = "1.2.0", path = "nym-api" } | ||
| nym-bandwidth-controller = { version = "1.2.0", path = "common/bandwidth-controller" } |
There was a problem hiding this comment.
I'm not sure you have to specify the version on top here (plz double check), but if not, i'd remove it so we wouldn't cause some inconsistencies if we forget to update those
There was a problem hiding this comment.
This was the hacky way I found which allows us to define the workspace.version for the constituent crates. Maybe I can get rid of those.. Will experiment.
| [package] | ||
| name = "sqlx-pool-guard" | ||
| version = "0.1.0" | ||
| name = "nym-sqlx-pool-guard" |
There was a problem hiding this comment.
since you've renamed this, after the PR gets merged, create a draft on the vpn repo to update their dependencies (as they were importing it too)
There was a problem hiding this comment.
note to self - check where this occurs elsewhere
- prepend sqlx-pool-guard with 'nym-'
mfahampshire
force-pushed
the
max/crates-io-prep-v2
branch
from
f7df17e to
aea7607
Compare
This PR makes the necessary modifications to be able to publish the majority of the Nym monorepo workspace crates to https://crates.io (essentially everything aside from binaries, internal tools, and a few select other things).
Overall, this PR:
adds a script to usecargo releaseto publish the SDK + its dependencies -cargo releasedeals with creating them in the correct ordercargo.tomlfilecargo.tomlpathto using theworkspaceversionTodo:
gitcratesblscrate: upload fork to crates.iogitimport to0.8.0from crates as per PRcontracts/workspace - TEMP in max/crates-io-prep-v2-contract-experimentnym-credential-verificationcompilation errs in dryrunpublishing.mdwriteupnym/common/wasm/utils/src/websocket/mod.rs
Line 49 in 0392778
This change is